improvements on current gtk-4 drastic branch#380
Open
notAxion wants to merge 9 commits intotrigg:drasticfrom
Open
improvements on current gtk-4 drastic branch#380notAxion wants to merge 9 commits intotrigg:drasticfrom
notAxion wants to merge 9 commits intotrigg:drasticfrom
Conversation
seems to fix few known issues - changing the text side option from the settings menu wouldn't update the overlay right away - somehow adding an initial padding when opened on a environment with no previous config still not sure if this is the right way to fix this.
grk color button is deprecated, migrated to gtk color dialog
…ed and config set correctly _param=None is just another param because i had to change to a different signal (to notifiy::rgba)
…button after reading config file seems this is the way to initialize RGBA now
…hole user with name also fixes the border showing on the background while avatar is transparent
…together gtk box was created to have a separete css class so only avatar gets affected when changing the opacity
Author
|
had plans to do more with this, and i might if i get free again but for now i will get busy so i wanted to create this PR to share how much i have done so far, check on this when you can and tell me if you need some changes on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
few main improvements involves:
known caveats that still exist: