Support LB spec & coordinator-only annotations #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirislav
force-pushed
the
coordinator-specific-annotations-and-supporting-generic-service-attributes
branch
from
fbcd41b to
c536f4b
Compare
jirislav
force-pushed
the
coordinator-specific-annotations-and-supporting-generic-service-attributes
branch
from
c536f4b to
3ae4992
Compare
| @@ -550,6 +550,21 @@ secretMounts: [] | |||
| # ``` | |||
|
|
|||
| coordinator: | |||
| service: {} | |||
| # coordinator.service -- Service overrides just for the coordinator service. It is merged with the root-level service specification. Beware that specifying spec.ports will override the dynamically generated ports for JMX exporter as well as the additionalExposedPorts. | |||
There was a problem hiding this comment.
IMO, we should not allow specifying both the top-level service and coordinator or worker services. It's too easy to make a mistake, like specifying the wrong type, and one will be ignored.
There's a similar PR #360 and we had this discussion there: #360 (comment)
| @@ -1,4 +1,7 @@ | |||
| {{- $workerJmx := merge .Values.jmx.worker (omit .Values.jmx "coordinator" "worker") -}} | |||
| {{- $workerSvcSpecOverride := index .Values.worker.service "spec" | default dict -}} | |||
There was a problem hiding this comment.
This template gets pretty complicated, and we need to update tests to cover at least parts of the new use cases supported. See if you could update tests/trino/test-values.yaml. If not, create a new test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #366