Skip to content

import get_localzone_name only if timezone not avaiable #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

import get_localzone_name only if timezone not avaiable #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions trino/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
from requests import Response
from requests import Session
from requests.structures import CaseInsensitiveDict
from tzlocal import get_localzone_name # type: ignore

import trino.logging
from trino import constants
Expand Down Expand Up @@ -184,9 +183,12 @@ def __init__(
self._extra_credential = extra_credential
self._client_tags = client_tags.copy() if client_tags is not None else list()
self._roles = self._format_roles(roles) if roles is not None else {}
self._timezone = timezone or get_localzone_name()
if timezone: # Check timezone validity
ZoneInfo(timezone)
self._timezone = timezone
else:
from tzlocal import get_localzone_name
self._timezone = get_localzone_name()
self._encoding = encoding

@property
Expand Down