Skip to content

[Closed Duplicate] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Closed Duplicate] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea52364
Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exaso…
skyglass Jul 17, 2025
8c84f65
Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exaso…
skyglass Jul 17, 2025
93f7eef
Add support for TIMESTAMP types in Exasol connector
skyglass Jul 22, 2025
04a3e6c
Merge remote-tracking branch 'origin/feature/724_additional_data_type…
skyglass Jul 22, 2025
68ec52e
Update exasol db version to 8.34.0 in tests
skyglass Jul 22, 2025
7756c66
Merge remote-tracking branch 'origin/feature/724_additional_data_type…
skyglass Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
296 changes: 296 additions & 0 deletions plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
import io.trino.plugin.jdbc.JdbcTypeHandle;
import io.trino.plugin.jdbc.LongReadFunction;
import io.trino.plugin.jdbc.LongWriteFunction;
import io.trino.plugin.jdbc.ObjectReadFunction;
import io.trino.plugin.jdbc.ObjectWriteFunction;
import io.trino.plugin.jdbc.QueryBuilder;
import io.trino.plugin.jdbc.WriteFunction;
import io.trino.plugin.jdbc.WriteMapping;
Expand All @@ -39,42 +41,81 @@
import io.trino.spi.connector.ColumnPosition;
import io.trino.spi.connector.ConnectorSession;
import io.trino.spi.connector.ConnectorTableMetadata;
import io.trino.spi.type.LongTimestamp;
import io.trino.spi.type.LongTimestampWithTimeZone;
import io.trino.spi.type.TimestampType;
import io.trino.spi.type.TimestampWithTimeZoneType;
import io.trino.spi.type.Type;

import java.sql.Connection;
import java.sql.Date;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.sql.Timestamp;
import java.sql.Types;
import java.time.Instant;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.time.ZoneOffset;
import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeFormatterBuilder;
import java.time.temporal.ChronoField;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.OptionalLong;
import java.util.Set;

import static com.google.common.base.Preconditions.checkArgument;
import static io.trino.plugin.jdbc.PredicatePushdownController.FULL_PUSHDOWN;
import static io.trino.plugin.jdbc.StandardColumnMappings.bigintColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.booleanColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.decimalColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.defaultCharColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.defaultVarcharColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.doubleColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.fromLongTrinoTimestamp;
import static io.trino.plugin.jdbc.StandardColumnMappings.fromTrinoTimestamp;
import static io.trino.plugin.jdbc.StandardColumnMappings.integerColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.smallintColumnMapping;
import static io.trino.plugin.jdbc.StandardColumnMappings.toLongTrinoTimestamp;
import static io.trino.plugin.jdbc.StandardColumnMappings.toTrinoTimestamp;
import static io.trino.plugin.jdbc.TypeHandlingJdbcSessionProperties.getUnsupportedTypeHandling;
import static io.trino.plugin.jdbc.UnsupportedTypeHandling.CONVERT_TO_VARCHAR;
import static io.trino.spi.StandardErrorCode.NOT_SUPPORTED;
import static io.trino.spi.connector.ConnectorMetadata.MODIFYING_ROWS_MESSAGE;
import static io.trino.spi.type.DateTimeEncoding.packDateTimeWithZone;
import static io.trino.spi.type.DateTimeEncoding.unpackMillisUtc;
import static io.trino.spi.type.DateType.DATE;
import static io.trino.spi.type.DecimalType.createDecimalType;
import static io.trino.spi.type.TimeZoneKey.UTC_KEY;
import static io.trino.spi.type.TimestampType.createTimestampType;
import static io.trino.spi.type.TimestampWithTimeZoneType.createTimestampWithTimeZoneType;
import static io.trino.spi.type.Timestamps.PICOSECONDS_PER_NANOSECOND;
import static java.lang.String.format;
import static java.time.ZoneOffset.UTC;
import static java.util.Locale.ENGLISH;

public class ExasolClient
extends BaseJdbcClient
{
private static final int EXASOL_TIMESTAMP_WITH_TIMEZONE = 124;

private static final Set<String> INTERNAL_SCHEMAS = ImmutableSet.<String>builder()
.add("EXA_STATISTICS")
.add("SYS")
.build();

private static final int MAX_EXASOL_TIMESTAMP_PRECISION = 9;

private static final DateTimeFormatter TIMESTAMP_NANO_OPTIONAL_FORMATTER = new DateTimeFormatterBuilder()
.appendPattern("uuuu-MM-dd HH:mm:ss")
.optionalStart()
.appendFraction(ChronoField.NANO_OF_SECOND, 0, 9, true)
.optionalEnd()
.toFormatter();

@Inject
public ExasolClient(
BaseJdbcConfig config,
Expand Down Expand Up @@ -229,6 +270,10 @@ public Optional<ColumnMapping> toColumnMapping(ConnectorSession session, Connect
return Optional.of(defaultVarcharColumnMapping(typeHandle.requiredColumnSize(), true));
case Types.DATE:
return Optional.of(dateColumnMapping());
case Types.TIMESTAMP:
return Optional.of(timestampColumnMapping(typeHandle));
case EXASOL_TIMESTAMP_WITH_TIMEZONE:
return Optional.of(timestampWithTimeZoneColumnMapping(typeHandle));
}

if (getUnsupportedTypeHandling(session) == CONVERT_TO_VARCHAR) {
Expand All @@ -237,6 +282,257 @@ public Optional<ColumnMapping> toColumnMapping(ConnectorSession session, Connect
return Optional.empty();
}

private static ColumnMapping timestampColumnMapping(JdbcTypeHandle typeHandle)
{
int timestampPrecision = typeHandle.requiredDecimalDigits();
TimestampType timestampType = createTimestampType(timestampPrecision);
if (timestampType.isShort()) {
return ColumnMapping.longMapping(
timestampType,
longTimestampReadFunction(timestampType),
longTimestampWriteFunction(timestampType),
FULL_PUSHDOWN);
}
return ColumnMapping.objectMapping(
timestampType,
objectTimestampReadFunction(timestampType),
objectTimestampWriteFunction(timestampType),
FULL_PUSHDOWN);
}

private static LongReadFunction longTimestampReadFunction(TimestampType timestampType)
{
return (resultSet, columnIndex) -> {
Timestamp timestamp = resultSet.getObject(columnIndex, Timestamp.class);
return toTrinoTimestamp(timestampType, timestamp.toLocalDateTime());
};
}

private static ObjectReadFunction objectTimestampReadFunction(TimestampType timestampType)
{
verifyObjectTimestampPrecision(timestampType);
return ObjectReadFunction.of(
LongTimestamp.class,
(resultSet, columnIndex) -> {
Timestamp timestamp = resultSet.getObject(columnIndex, Timestamp.class);
return toLongTrinoTimestamp(timestampType, timestamp.toLocalDateTime());
});
}

private static void verifyObjectTimestampPrecision(TimestampType timestampType)
{
int precision = timestampType.getPrecision();
checkArgument(precision > TimestampType.MAX_SHORT_PRECISION && precision <= MAX_EXASOL_TIMESTAMP_PRECISION,
"Precision is out of range: %s", precision);
}

private static ObjectWriteFunction objectTimestampWriteFunction(TimestampType timestampType)
{
int precision = timestampType.getPrecision();
verifyObjectTimestampPrecision(timestampType);

return new ObjectWriteFunction() {
@Override
public Class<?> getJavaType()
{
return LongTimestamp.class;
}

@Override
public void set(PreparedStatement statement, int index, Object value)
throws SQLException
{
LocalDateTime timestamp = fromLongTrinoTimestamp((LongTimestamp) value, precision);
statement.setString(index, TIMESTAMP_NANO_OPTIONAL_FORMATTER.format(timestamp));
}

@Override
public String getBindExpression()
{
return getTimestampBindExpression(precision);
}

@Override
public void setNull(PreparedStatement statement, int index)
throws SQLException
{
statement.setNull(index, Types.VARCHAR);
}
};
}

private static LongWriteFunction longTimestampWriteFunction(TimestampType timestampType)
{
return new LongWriteFunction()
{
@Override
public String getBindExpression()
{
return getTimestampBindExpression(timestampType.getPrecision());
}

@Override
public void set(PreparedStatement statement, int index, long epochMicros)
throws SQLException
{
LocalDateTime localDateTime = fromTrinoTimestamp(epochMicros);
Timestamp timestampValue = Timestamp.valueOf(localDateTime);
statement.setObject(index, timestampValue);
}

@Override
public void setNull(PreparedStatement statement, int index)
throws SQLException
{
statement.setNull(index, Types.VARCHAR);
}
};
}

private static ColumnMapping timestampWithTimeZoneColumnMapping(JdbcTypeHandle typeHandle)
{
int timestampPrecision = typeHandle.requiredDecimalDigits();
TimestampWithTimeZoneType timestampWithTimeZoneType = createTimestampWithTimeZoneType(timestampPrecision);

if (timestampWithTimeZoneType.isShort()) {
return ColumnMapping.longMapping(
timestampWithTimeZoneType,
longTimestampWithTimeZoneReadFunction(),
longTimestampWithTimeZoneWriteFunction(timestampWithTimeZoneType),
FULL_PUSHDOWN);
}
return ColumnMapping.objectMapping(
timestampWithTimeZoneType,
objectTimestampWithTimeZoneReadFunction(timestampWithTimeZoneType),
objectTimestampWithTimeZoneWriteFunction(timestampWithTimeZoneType),
FULL_PUSHDOWN);
}

private static LongReadFunction longTimestampWithTimeZoneReadFunction()
{
return (resultSet, columnIndex) -> {
Timestamp timestamp = resultSet.getObject(columnIndex, Timestamp.class);
return packDateTimeWithZone(timestamp.getTime(), UTC_KEY);
};
}

private static ObjectReadFunction objectTimestampWithTimeZoneReadFunction(
TimestampWithTimeZoneType timestampType)
{
verifyObjectTimestampWithTimeZonePrecision(timestampType);
return ObjectReadFunction.of(
LongTimestampWithTimeZone.class,
(resultSet, columnIndex) -> {
Timestamp timestamp = resultSet.getObject(columnIndex, Timestamp.class);
if (timestamp == null) {
return null;
}

long millisUtc = timestamp.getTime();
long nanosUtc = millisUtc * 1_000_000L + timestamp.getNanos() % 1_000_000;
int picosOfMilli = (int) ((nanosUtc - millisUtc * 1_000_000) * 1_000);

return LongTimestampWithTimeZone.fromEpochMillisAndFraction(
millisUtc,
picosOfMilli,
UTC_KEY);
});
}

private static void verifyObjectTimestampWithTimeZonePrecision(TimestampWithTimeZoneType timestampType)
{
int precision = timestampType.getPrecision();
checkArgument(precision > TimestampWithTimeZoneType.MAX_SHORT_PRECISION && precision <= MAX_EXASOL_TIMESTAMP_PRECISION,
"Precision is out of range: %s", precision);
}

private static ObjectWriteFunction objectTimestampWithTimeZoneWriteFunction(TimestampWithTimeZoneType timestampType)
{
int precision = timestampType.getPrecision();
verifyObjectTimestampWithTimeZonePrecision(timestampType);

return new ObjectWriteFunction() {
@Override
public Class<?> getJavaType()
{
return LongTimestampWithTimeZone.class;
}

@Override
public void set(PreparedStatement statement, int index, Object value)
throws SQLException
{
if (value == null) {
statement.setNull(index, Types.VARCHAR);
return;
}

LongTimestampWithTimeZone timestampValue = (LongTimestampWithTimeZone) value;

long epochMillis = timestampValue.getEpochMillis();
int picosOfMilli = timestampValue.getPicosOfMilli();
int nanos = picosOfMilli / PICOSECONDS_PER_NANOSECOND;

Instant instant = Instant.ofEpochMilli(epochMillis).plusNanos(nanos);
ZonedDateTime zonedDateTime = instant.atZone(UTC);

String formatted = TIMESTAMP_NANO_OPTIONAL_FORMATTER.format(zonedDateTime);
statement.setString(index, formatted);
}

@Override
public String getBindExpression()
{
return getTimestampBindExpression(precision);
}

@Override
public void setNull(PreparedStatement statement, int index)
throws SQLException
{
statement.setNull(index, Types.VARCHAR);
}
};
}

private static LongWriteFunction longTimestampWithTimeZoneWriteFunction(TimestampWithTimeZoneType timestampType)
{
return new LongWriteFunction()
{
@Override
public String getBindExpression()
{
return getTimestampBindExpression(timestampType.getPrecision());
}

@Override
public void set(PreparedStatement statement, int index, long epochMicros)
throws SQLException
{
Instant instant = Instant.ofEpochMilli(unpackMillisUtc(epochMicros));
LocalDateTime localDateTime = instant.atZone(ZoneOffset.UTC).toLocalDateTime();
statement.setString(index, TIMESTAMP_NANO_OPTIONAL_FORMATTER.format(localDateTime));
}

@Override
public void setNull(PreparedStatement statement, int index)
throws SQLException
{
statement.setNull(index, Types.VARCHAR);
}
};
}

private static String getTimestampBindExpression(int precision)
{
if (precision <= 0) {
return "TO_TIMESTAMP(?, 'YYYY-MM-DD HH24:MI:SS')";
}
else {
return format("TO_TIMESTAMP(?, 'YYYY-MM-DD HH24:MI:SS.FF%d')", precision);
}
}

private static ColumnMapping dateColumnMapping()
{
// Exasol driver does not support LocalDate
Expand Down
Loading
Loading