-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[Draft] Add support for TIMESTAMP and TIMESTAMP WITH TIME ZONE types in Exasol connector #26259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
37a2fe5
to
78d1495
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
c950205
to
d7ff56f
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
1 similar comment
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
ef6b95a
to
07a421f
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/exasol/TestExasol.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Outdated
Show resolved
Hide resolved
07a421f
to
0d4b20a
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
0d4b20a
to
bd554f9
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
bd554f9
to
4ff3087
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
3 similar comments
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
2a722d5
to
2c0b293
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Show resolved
Hide resolved
2c0b293
to
cb525e5
Compare
Hello everyone! Is anything missing on this PR? Looking forward to having it merged! |
47da9cf
to
3035c52
Compare
Thank you very much for your reviews, @ebyhr , @chenjian2664 ! 👍 Any updates on the PR? |
3035c52
to
d94b914
Compare
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Outdated
Show resolved
Hide resolved
d94b914
to
fb10175
Compare
fb10175
to
ab0858d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the review comments, @ebyhr , @chenjian2664 ! 👍
I have resolved the conversations and added code changes, based on the review comments.
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-exasol/src/test/java/io/trino/plugin/exasol/TestExasolTypeMapping.java
Outdated
Show resolved
Hide resolved
0270c0e
to
e1eaaeb
Compare
plugin/trino-exasol/src/main/java/io/trino/plugin/exasol/ExasolClient.java
Show resolved
Hide resolved
e1eaaeb
to
1fda337
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to move this PR to DRAFT and replace it with the new PR, with more simple, more efficient and less error-prone solution: #26633
Please, review the new PR, @ebyhr , @chenjian2664 ! 🙏
After reviewing the implementation, I believe the current approach - mapping Exasol TIMESTAMP WITH LOCAL TIME ZONE to Trino TIMESTAMP WITH TIME ZONE - adds unnecessary complexity and potential pitfalls.
Exasol TIMESTAMP WITH LOCAL TIME ZONE does not actually persist any time zone information. Apart from some minor edge cases, its semantics is very close to a plain Exasol TIMESTAMP.
Mapping to Trino TIMESTAMP WITH TIME ZONE requires hardcoding the JVM time zone, which introduces fragility. For example, values valid in the Exasol DB time zone but invalid in the JVM time zone (e.g., during DST gaps) may cause Trino to throw exceptions, potentially breaking queries.
A simpler mapping to Trino TIMESTAMP avoids these problems, is more efficient, and aligns better with how Exasol handles this type internally.
Given this, I created a new PR proposing the TIMESTAMP WITH LOCAL TIME ZONE → TIMESTAMP mapping, which I believe will result in a cleaner, simpler and more reliable solution: #26633
Closed as outdated. See the new PR with improved solution for Exasol TIMESTAMP WITH LOCAL TIME ZONE: #26633 |
Does the timestamp part is the same as new pr #26259 ? |
The new PR is here: #26633 The main difference is that the new PR maps Exasol TIMESTAMP WITH LOCAL TIME ZONE to Trino TIMESTAMP. This current PR was closed, because it was mapping Exasol TIMESTAMP WITH LOCAL TIME ZONE to Trino TIMESTAMP WITH TIME ZONE, which is not necessary, because Exasol TIMESTAMP WITH LOCAL TIME ZONE doesn't actually store the time zone information. |
If it just about TIMESTAMP WITH LOCAL TIME ZONE, we could split to support TIMESTAMP first |
Description
Added Exasol Trino connector support for Timestamp and Timestamp With Local Time Zone JDBC data types
Additional context and related issues
Release notes