Skip to content

Restrict logical navigations to the running match in running semantics #27006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Restrict logical navigations to the running match in running semantics #27006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions core/trino-main/src/main/java/io/trino/operator/window/pattern/LogicalIndexNavigation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,26 +76,20 @@ public int resolvePosition(int currentRow, ArrayView matchedLabels, int searchSt
checkArgument(currentRow >= patternStart && currentRow < patternStart + matchedLabels.length(), "current row is out of bounds of the match");

int relativePosition;
int patternEndInclusive = running ? currentRow - patternStart : matchedLabels.length() - 1;
if (last) {
int start;
if (running) {
start = currentRow - patternStart;
}
else {
start = matchedLabels.length() - 1;
}
relativePosition = findLastAndBackwards(start, matchedLabels);
relativePosition = findLastAndBackwards(patternEndInclusive, matchedLabels);
}
else {
relativePosition = findFirstAndForward(matchedLabels);
relativePosition = findFirstAndForward(matchedLabels, patternEndInclusive);
}
return adjustPosition(relativePosition, patternStart, searchStart, searchEnd);
}

// LAST(A.price, 3): find the last occurrence of label "A" and go 3 occurrences backwards
private int findLastAndBackwards(int searchStart, ArrayView matchedLabels)
private int findLastAndBackwards(int patternEndInclusive, ArrayView matchedLabels)
{
int position = searchStart + 1;
int position = patternEndInclusive + 1;
int found = 0;
while (found <= logicalOffset && position > 0) {
position--;
Expand All @@ -110,11 +104,11 @@ private int findLastAndBackwards(int searchStart, ArrayView matchedLabels)
}

// FIRST(A.price, 3): find the first occurrence of label "A" and go 3 occurrences forward
private int findFirstAndForward(ArrayView matchedLabels)
private int findFirstAndForward(ArrayView matchedLabels, int patternEndInclusive)
{
int position = -1;
int found = 0;
while (found <= logicalOffset && position < matchedLabels.length() - 1) {
while (found <= logicalOffset && position < patternEndInclusive) {
position++;
if (labels.isEmpty() || labels.contains(matchedLabels.get(position))) {
found++;
Expand Down
4 changes: 2 additions & 2 deletions core/trino-main/src/test/java/io/trino/sql/query/TestRowPatternMatching.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,8 +1020,8 @@ public void testNavigationFunctions()

assertThat(assertions.query(format(query, "FIRST(value, 2)")))
.matches("VALUES " +
" (1, 30), " +
" (2, 30), " +
" (1, null), " +
" (2, null), " +
" (3, 30) ");

assertThat(assertions.query(format(query, "LAST(value, 10)")))
Expand Down
Loading