Re-throw StorageException as IOException

[mrcnc]

Description

Updates the close method GcsOutputStream to re-throw StorageException as IOException to avoid silently swallowing them.

Additional context and related issues

Currently when a StorageException is thrown, it is silently swallowed except if it's an HTTP 412. Therefore it's possible that a file was never written to GCS because of some other transient networking error, but the stream is marked as closed.

I checked the S3 implementation and see that it similarly re-throws these types of exceptions as IOException so this is consistent with other filesystem behavior.

I came across this code while investigating an issue we encountered in one of our Iceberg tables. We can see files tracked in the Iceberg metadata that do not exist in the GCS bucket so it makes me suspect this is the root cause.

Release notes

( x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Bug Fixes:

• Re-throw StorageException as IOException instead of swallowing it in GcsOutputStream.close to surface failures

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR modifies the GcsOutputStream.close method to catch any StorageException and immediately wrap it in an IOException rather than ignoring it, ensuring transient GCS errors aren’t silently dropped and aligning with S3OutputStream’s behavior.

Class diagram for updated GcsOutputStream.close exception handling

classDiagram
    class GcsOutputStream {
        +void close()
    }
    class StorageException {
        +int getCode()
    }
    class IOException
    class FileAlreadyExistsException
    GcsOutputStream --> StorageException : catches
    GcsOutputStream --> IOException : rethrows
    GcsOutputStream --> FileAlreadyExistsException : throws if HTTP 412

Loading

File-Level Changes

Change	Details	Files
Wrap StorageException as IOException in close()	Add 'throw new IOException(e)' in the StorageException catch block	lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsOutputStream.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}