Open
Conversation
phalestrivir
requested changes
Dec 16, 2025
Collaborator
phalestrivir
left a comment
There was a problem hiding this comment.
Looks good, but there are two things that need to be done still:
- Run
npm run lint:fixto fix the linting issues - Some of the tests are now failing due to the new progress indicators, namely anything related to snapshots which are snapshotting the output. I believe the problem is that before the progress indicators used to be considered "error" output, but now they are "standard" output. I think having them be "standard" output makes sense (I'm not actually sure what the reason is why they were originally error output, this may be something we want to confirm with Huston/Volker), but we'll need to update the snapshots accordingly.
d7d59de to
1d37188
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New progress bars will not overwrite each other nor the console outputs. New spinners, loading bars, and handling stdout and stderr messages,