WIP: add arbitrary torography on P4estMeshCubedSphere#187
Draft
MarcoArtiano wants to merge 3 commits intomainfrom
Draft
WIP: add arbitrary torography on P4estMeshCubedSphere#187MarcoArtiano wants to merge 3 commits intomainfrom
P4estMeshCubedSphere#187MarcoArtiano wants to merge 3 commits intomainfrom
Conversation
MarcoArtiano
changed the title
P4estCubedSphereP4estMeshCubedSphere
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 97.11% 96.10% -1.02%
==========================================
Files 38 39 +1
Lines 5128 5182 +54
==========================================
Hits 4980 4980
- Misses 148 202 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcoArtiano
changed the title
P4estMeshCubedSphereP4estMeshCubedSphere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other than baroclinic test case with real horography, some idealized test cases with horography are really interesting and I will add them in this PR (at least 1 for having 1 case with real horography and 1 idealized one):
https://sites.google.com/umich.edu/dcmip-2025/dcmip-2025-test-cases/test-case-2-mountain-triggered-meso-scale-flow-phenomena.
The visualization has been realized by clipping the data in paraview with radius = 6371300.
With the horography, two functions are implemented to adapt the vertical size elements to smoothly restore the cubed sphere.