Open
Conversation
trmazi
approved these changes
Jan 4, 2022
trmazi
requested changes
Jan 4, 2022
Owner
trmazi
left a comment
There was a problem hiding this comment.
There are a few issues with this file.
- Clean up the imports please
- Please make sure that the 3 inputs are uppercase
- Make sure that all 3 checks have
exit() CompileDongis expecting the mcode in an array, not a full string.
def makeBlackDong(key:str, mcode:list, pcbid):
Also, if you reread CompileDong, you'll see that there's actually a slightly different signing process for making a white dongle, and making one in the same way as a black dongle will not work. You'll need to separate them somehow.
Author
|
1, 2, 3: ok |
Owner
|
Thanks for the changes, and about the last one, Lastly, please add .bin to the output filename. Other than that, tested working (only for black dongles) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit is self-explanatory