Skip to content

add backend: litellm#1

Open
nilshamerlinck wants to merge 1 commit intotrobz:mainfrom
nilshamerlinck:litellm
Open

add backend: litellm#1
nilshamerlinck wants to merge 1 commit intotrobz:mainfrom
nilshamerlinck:litellm

Conversation

@nilshamerlinck
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@hailangvn hailangvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor changes.

Comment thread agent/agent.py
@@ -1,5 +1,6 @@
#!/usr/bin/python3

import os
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason we need to split to new import group?

Suggested change
import os
import litellm
import os

Comment thread agent/agent.py
Comment on lines +13 to +14
import litellm

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick to keep import in one group.

Suggested change
import litellm

Comment thread agent/agent.py
print(content)


def run_agent(cwd, instructions, backend, mode, model, litellm_base_url, litellm_api_key, litellm_provider):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def run_agent(cwd, instructions, backend, mode, model, litellm_base_url, litellm_api_key, litellm_provider):
def run_agent(
cwd,
instructions,
backend,
mode,
model,
litellm_base_url,
litellm_api_key,
litellm_provider
):

Comment thread agent/agent.py


def run_workflow(workflow_dir, workflow, backend, mode, model):
def run_workflow(workflow_dir, workflow, backend, mode, model, litellm_base_url, litellm_api_key, litellm_provider):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def run_workflow(workflow_dir, workflow, backend, mode, model, litellm_base_url, litellm_api_key, litellm_provider):
def run_workflow(
workflow_dir,
workflow,
backend,
mode,
model,
litellm_base_url,
litellm_api_key,
litellm_provider
):

Comment thread pyproject.toml
dependencies = [
"typer>=0.19.2"
"typer>=0.19.2",
"litellm>=1.52.0",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help to bump project version in line no. 3 to 0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants