Conversation
| Type=simple | ||
| WorkingDirectory={{ instance_path }} | ||
| ExecStart={{ venv_path }}/bin/python -m {{ exec_start }} | ||
| ExecStart={{ venv_path }}/bin/python {{ exec_entry }} |
Contributor
There was a problem hiding this comment.
Suggested change
| ExecStart={{ venv_path }}/bin/python {{ exec_entry }} | |
| ExecStart={{ venv_path }}/bin/{{ exec_entry }} |
Contributor
There was a problem hiding this comment.
after second thought, I think it's better to give more freedom there
e.g. for a fastapi app, might run fastapi binary directly
Collaborator
Author
There was a problem hiding this comment.
Thanks for your review. This has been updated.
hailangvn
force-pushed
the
imp-deploy
branch
2 times, most recently
from
952fe15 to
9e356bb
Compare
Comment on lines
+128
to
+134
| odoo_addons_path = executor.capture("which odoo-addons-path") | ||
| template_vars["odoo_addons_path"] = odoo_addons_path | ||
| odoo_path = executor.capture( | ||
| "odoo-addons-path odoo-path .", | ||
| cwd=instance_path, | ||
| ) | ||
| template_vars["odoo_path"] = odoo_path |
Contributor
There was a problem hiding this comment.
@hailangvn if we assume that odoo-venv installed odoo properly, then can't we just rely on the bin/odoo installed in the venv? as does @trisdoan in trobz/odoo-venv#68
Collaborator
Author
There was a problem hiding this comment.
Thanks for your review. The PR has been updated.
nilshamerlinck
approved these changes
Mar 26, 2026
- working dir and executable path in unit config file need to be absolute so home_dir is required and should be absolute. It replaces $HOME environment variable. - have git aggregator support for addons - use odoo-addons-path in unit config file to detect addons paths instead of hard-coding - allow file path for python type in addition of module path for python - update command now uses odoo-venv update with backup flag Forge ID: F#T67348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Forge ID: F#T67348