fix(presets): replace pyldap with python-ldap for Odoo 12#72
Closed
fix(presets): replace pyldap with python-ldap for Odoo 12#72
Conversation
trisdoan
force-pushed
the
fix/odoo-12-pyldap
branch
7 times, most recently
from
e3fe303 to
2e673e8
Compare
pyldap==2.4.28 fails to build on OpenLDAP 2.5+ (libldap_r merged into libldap). Replace with python-ldap, the upstream project Odoo 13+ already uses. Adds migration script per CI requirements for presets.toml changes.
trisdoan
force-pushed
the
fix/odoo-12-pyldap
branch
from
2e673e8 to
2aad564
Compare
Collaborator
Author
|
Superseded by #76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace unmaintained
pyldap==2.4.28withpython-ldapto fix build failures on OpenLDAP 2.5+.pyldap fails because libldap_r was merged into libldap in OpenLDAP 2.5, breaking the build. python-ldap is the upstream LDAP library Odoo 13+ already adopted.