Adding priority promotion en Zielonka variants with justifications.#4
Open
Rupsbant wants to merge 4 commits intotrolando:masterfrom
Open
Adding priority promotion en Zielonka variants with justifications.#4Rupsbant wants to merge 4 commits intotrolando:masterfrom
Rupsbant wants to merge 4 commits intotrolando:masterfrom
Conversation
Owner
|
Hi @Rupsbant, I tried importing but it does not compile? |
Owner
|
Oh another comment. It might be nicer to split the two/three solvers into separate commits, and have slightly improved commit messages. Keeps the master branch nice and clean, hopefully. |
241df56 to
10f67d6
Compare
a3cd3d1 to
6f849c7
Compare
Owner
|
I hope to get to this soon, pinky promise. |
f682d5a to
32950f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to add two, or three, justification variants to Oink: Oink-ppj is a priority promotion variant, Oink-zlkj is a variant of Zielonka's algorithm with a hashset and Oink-zlkjb is a non-hashset variant.
The application of justifications to parity games has been described in "Improving Parity Game Solvers with Justifications."
I would be happy to explain and modify the source code to match your requirements.
Kind regards
Ruben