Skip to content

Adding priority promotion en Zielonka variants with justifications.#4

Open
Rupsbant wants to merge 4 commits intotrolando:masterfrom
Rupsbant:ppjf
Open

Adding priority promotion en Zielonka variants with justifications.#4
Rupsbant wants to merge 4 commits intotrolando:masterfrom
Rupsbant:ppjf

Conversation

@Rupsbant
Copy link

@Rupsbant Rupsbant commented Jan 18, 2020

Hi,

I would like to add two, or three, justification variants to Oink: Oink-ppj is a priority promotion variant, Oink-zlkj is a variant of Zielonka's algorithm with a hashset and Oink-zlkjb is a non-hashset variant.

The application of justifications to parity games has been described in "Improving Parity Game Solvers with Justifications."

I would be happy to explain and modify the source code to match your requirements.

Kind regards
Ruben

@Rupsbant Rupsbant requested a review from trolando January 23, 2020 03:42
@trolando
Copy link
Owner

Hi @Rupsbant, I tried importing but it does not compile?
You moved the struct out of the header file to the implementation, but this breaks compilation.
Just adding the struct without content seems to work though. Haven't done a more detailed check yet.
However I did also test quickly on my development branch and it seems to pass the random test bench as well as the internal tests, so that's good.

@trolando
Copy link
Owner

Oh another comment. It might be nicer to split the two/three solvers into separate commits, and have slightly improved commit messages. Keeps the master branch nice and clean, hopefully.

@trolando trolando force-pushed the master branch 2 times, most recently from 241df56 to 10f67d6 Compare July 26, 2022 11:38
@trolando trolando force-pushed the master branch 7 times, most recently from a3cd3d1 to 6f849c7 Compare October 25, 2023 22:59
@trolando
Copy link
Owner

I hope to get to this soon, pinky promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants