Recursive implementation of zdd_eval#35
Open
marek-zeleny wants to merge 3 commits intotrolando:masterfrom
Open
Recursive implementation of zdd_eval#35marek-zeleny wants to merge 3 commits intotrolando:masterfrom
marek-zeleny wants to merge 3 commits intotrolando:masterfrom
Conversation
trolando
force-pushed
the
master
branch
2 times, most recently
from
ba13229 to
74578fb
Compare
Owner
|
I'll check this out later, what is the purpose of this version? I.e. use case? |
trolando
force-pushed
the
master
branch
4 times, most recently
from
2afc4d7 to
4013c97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have re-implemented the
zdd_eval()operator to work also in the general case, i.e. for variables that are not in the root of the evaluated ZDD. The algorithm is taken from the following paper, where it's calledsubset0, resp.subset1:Shin-ichi Minato. 1993. Zero-suppressed BDDs for set manipulation in combinatorial problems. In Proceedings of the 30th international Design Automation Conference (DAC '93). Association for Computing Machinery, New York, NY, USA, 272–277. https://doi.org/10.1145/157485.164890
I have also added some test cases for this operation and have since used it as a subroutine in other algorithms, where it seems to be yielding correct results. I hope I have correctly used the library's internals (caching, protection from GC, ...).