add quick passover countdown / inprogress app#415
add quick passover countdown / inprogress app#415jvivona wants to merge 6 commits intotronbyt:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new 'Passover' applet designed to provide timely information about the holiday. The applet intelligently determines whether to show a countdown to the upcoming Passover or to indicate which day of the 8-day celebration it currently is, offering a culturally relevant and informative display. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR adds a new Passover app. The review found several issues requiring attention. Unused modules are imported. The app uses a hardcoded, expiring list of dates, which poses a significant maintainability risk; consider moving this data to a separate file. The code contains a bug using an incorrect timezone, a block of dead code, and can be refactored for clarity. The comment regarding 2x rendering support was removed as it contradicts repository guidelines.
like i don't know how to build tidbyt / tronbyt apps at all :-)
No description provided.