Skip to content

add quick passover countdown / inprogress app#415

Closed
jvivona wants to merge 6 commits intotronbyt:mainfrom
jvivona:main
Closed

add quick passover countdown / inprogress app#415
jvivona wants to merge 6 commits intotronbyt:mainfrom
jvivona:main

Conversation

@jvivona
Copy link
Contributor

@jvivona jvivona commented Mar 19, 2026

No description provided.

@jvivona jvivona requested a review from tavdog as a code owner March 19, 2026 18:46
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new 'Passover' applet designed to provide timely information about the holiday. The applet intelligently determines whether to show a countdown to the upcoming Passover or to indicate which day of the 8-day celebration it currently is, offering a culturally relevant and informative display.

Highlights

  • New Applet Introduction: A new Starlark applet named 'Passover' has been added to the applications directory.
  • Dynamic Display Logic: The applet dynamically displays either a countdown to the next Passover or the current day of the 8-day celebration.
  • Date Management: Hardcoded Passover dates from 2026 to 2036 are included to facilitate accurate calculations.
  • Multilingual Support: Hebrew text is incorporated into the display for cultural relevance during the celebration and countdown.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds a new Passover app. The review found several issues requiring attention. Unused modules are imported. The app uses a hardcoded, expiring list of dates, which poses a significant maintainability risk; consider moving this data to a separate file. The code contains a bug using an incorrect timezone, a block of dead code, and can be refactored for clarity. The comment regarding 2x rendering support was removed as it contradicts repository guidelines.

@jvivona jvivona closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant