Skip to content

fix(frcteamrank): handle null qual data from The Blue Alliance API #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tavdog merged 2 commits into from
Mar 20, 2026
Merged

fix(frcteamrank): handle null qual data from The Blue Alliance API #418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b24fc9d
fix(frcteamrank): handle null qual data from The Blue Alliance API
dragid10 Mar 20, 2026
8d638a4
refactor(frcteamrank): use intermediate variables and .get() for rank…
dragid10 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions apps/frcteamrank/frc_team_rank.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,17 +157,23 @@ def get_team_ranking(team_number, event_key, tba_api_key):
team_ranking_error = MSG_TEAM_RANKING_ERROR % team_number
fail("%s - Status code: %s" % (team_ranking_error, team_ranking_resp.status_code))

# Parse the team ranking data
# Parse the team ranking data using intermediate variables.
# TBA returns qual/ranking/rank as nested objects, but any level can be
# None (not just missing) when the event hasn't started matches yet.
ranking_data = team_ranking_resp.json()
if "qual" not in ranking_data:
qual_data = ranking_data.get("qual")
if not qual_data:
return -1, 999
if "ranking" not in ranking_data["qual"]:

ranking_info = qual_data.get("ranking")
if not ranking_info:
return -1, 999
if "rank" not in ranking_data["qual"]["ranking"]:

team_ranking = ranking_info.get("rank")
if team_ranking == None:
return -1, 999
team_ranking = ranking_data["qual"]["ranking"]["rank"]
total_teams = ranking_data["qual"]["num_teams"]

total_teams = ranking_info.get("num_teams", 999)
return team_ranking, total_teams

def build_avatar_url(team_number):
Expand Down