Fix TypeError 'TextureImageFactory ' undefined#1
Open
qyvlik wants to merge 1 commit intotronlec:masterfrom
Open
Fix TypeError 'TextureImageFactory ' undefined#1qyvlik wants to merge 1 commit intotronlec:masterfrom
qyvlik wants to merge 1 commit intotronlec:masterfrom
Conversation
Fix TypeError 'TextureImageFactory ' undefined
miheikki
reviewed
Jun 20, 2017
Collaborator
miheikki
left a comment
miheikki
left a comment
There was a problem hiding this comment.
This fix wouldn't get into any newly generated three.js files, so it's not complete. These three.js files are generated by scripts under utils/build from various source files. If you need a change, it should also go somewhere in those source files so it will get to new versions if they are ever done. As for r71 version, that can no longer generated, so for that I guess this is correct place to fix it.
Also, while this may very well be a good fix, I don't have time to invest into testing if it causes any issues (unless management re-prioritizes things drastically), so I don't think this is likely to get approved any time soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TypeError 'TextureImageFactory ' undefined