fix(tests): flaky job ordering e2e test #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test verifies pmtr starts jobs in order based on the 'order' keyword by having each job write a timestamp to a file and checking timestamps are ascending. However, even though pmtr starts jobs in the correct order, OS scheduling can cause the timestamp writes to race. Fix by adding proportional sleep delays (0.1s, 0.2s, 0.3s) before each job writes its timestamp, ensuring the timestamps reflect start order.
imichaelmoore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
orderkeyword by comparing timestampsFix
Add proportional sleep delays (0.1s, 0.2s, 0.3s) before each job writes its timestamp, ensuring timestamps reflect the actual start order.
Test plan