This repository was archived by the owner on Jan 10, 2019. It is now read-only.
Upgrade bootstrap and fix NPE#28
Open
davejsmith wants to merge 7 commits intotrsvax:masterfrom
Open
Conversation
com.google.code.maven-play-plugin.com.yahoo.platform.yui:yuicompressor:jar:2.4.7. Should not be necessary for a module.
ghost
assigned
|
I guess, it would be best to send separate pull requests for those issues. That would make it easier to discuss or merge small changes and probably get important fixes (such as a20470f) merges faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are other changes you may not want. I removed the yuicompressor dependency because it wouldn't resolve from the maven repos that particular day. And added a Windows/Chrome profile for running the tests.
Thanks for the great work on this. My webapp looks/acts so much better with the Bootstrap styling.
-djs