Skip to content

crawling more information#53

Open
felixvonberlin wants to merge 11 commits intotrudi-group:mainfrom
felixvonberlin:main
Open

crawling more information#53
felixvonberlin wants to merge 11 commits intotrudi-group:mainfrom
felixvonberlin:main

Conversation

@felixvonberlin
Copy link
Copy Markdown

This pull request allows the crawler to determine:

  • the block height
  • the minimum transaction fee required, and
  • the ledger version
    of the crawled nodes.

It also allows the crawler to determine

  • the common required transaction fee, and
  • the common block height
    in the network, if possible.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 15, 2023

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Copy Markdown
Member

@cndolo cndolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @felixvonberlin.
There are, however, a couple of things that need to be addressed before merging.

Comment thread src/bin/mc-crawler.rs Outdated
Comment thread src/crawl/core_types.rs Outdated
Comment thread src/crawl/core_types.rs Outdated
Comment thread src/crawl/core_types.rs Outdated
Comment thread src/crawl/crawler.rs Outdated
Comment thread src/io/report.rs Outdated
Comment thread src/io/report.rs Outdated
Comment thread src/io/report.rs Outdated
Comment thread src/io/report.rs
Comment thread src/io/report.rs
@felixvonberlin
Copy link
Copy Markdown
Author

@cndolo I have followed most of your advice; but in some cases I would like to discuss them first.

@cndolo
Copy link
Copy Markdown
Member

cndolo commented Oct 23, 2023

Thanks for your patience and addressing the comments @felixvonberlin . I still have a few minor issues and would be willing to merge once you have addressed those.

@felixvonberlin
Copy link
Copy Markdown
Author

it's fixed ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants