-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Detector]-Detector for tableau personal access token #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SyedAliHamad
wants to merge
10
commits into
trufflesecurity:main
Choose a base branch
from
SyedAliHamad:detector/tableau-personal-access-token
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Detector]-Detector for tableau personal access token #4261
SyedAliHamad
wants to merge
10
commits into
trufflesecurity:main
from
SyedAliHamad:detector/tableau-personal-access-token
+848
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o detector/tableau-personal-access-token
shahzadhaider1
requested changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on putting together your first detector!
Added some feedback.
pkg/detectors/tableau/tableau.go
Outdated
Comment on lines
35
to
37
// Pattern for Personal Access Token Names - Updated to handle JSON | ||
tokenNamePat = regexp.MustCompile(`(?i)\b(?:personal[_-]?access[_-]?token[_-]?name|pat[_-]?name|token[_-]?name|access[_-]?token[_-]?name|api[_-]?token[_-]?name)[_\s]*[:=]\s*["\']?([a-zA-Z0-9_-]{3,50})["\']?`) | ||
quotedTokenNamePat = regexp.MustCompile(`(?i)["'](?:personal[_-]?access[_-]?token[_-]?name|pat[_-]?name|token[_-]?name|access[_-]?token[_-]?name|api[_-]?token[_-]?name)["']\s*:\s*["']([a-zA-Z0-9_-]{3,50})["']`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss this
…ub.com/SyedAliHamad/trufflehog into detector/tableau-personal-access-token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds new detector for Tableau Personal Access Tokens
Checklist:
make test-community
)?make lint
this requires golangci-lint)?