chore: bump kwil-db depedencies to prevent OOM crash#1336
Conversation
Time Submission Status
You can submit time with the command. Example: See available commands to help comply with our Guidelines. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds Go runtime memory tuning (GOMEMLIMIT=2500MiB, GOGC=50) to the tn-db service and increases container memory limits from 1.5G to 3G for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
compose.yaml (1)
62-65: Propagate memory tuning settings to dev-net environment for consistency.The
tn-db-1andtn-db-2services indeployments/dev-net/devnet-compose.yamllack the GOMEMLIMIT, GOGC, and memory deploy limits present in the maincompose.yaml. Adding these settings will ensure consistent memory behavior and OOM protection across development and production environments:
- GOMEMLIMIT (set to ~80% of memory limit)
- GOGC=50 (triggers GC at 50% heap growth)
- deploy.resources.limits.memory
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@compose.yaml` around lines 62 - 65, The dev environment services tn-db-1 and tn-db-2 are missing the memory tuning and limits present in the main compose; for each of those service definitions add an environment block with GOMEMLIMIT set to ~80% of the service memory limit (e.g., if memory: 3G then GOMEMLIMIT=2.4G), add GOGC=50, and add deploy.resources.limits.memory with the same value used in the main compose (e.g., 3G) so OOM protection and GC tuning are consistent; update both tn-db-1 and tn-db-2 entries accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@compose.yaml`:
- Around line 62-65: The dev environment services tn-db-1 and tn-db-2 are
missing the memory tuning and limits present in the main compose; for each of
those service definitions add an environment block with GOMEMLIMIT set to ~80%
of the service memory limit (e.g., if memory: 3G then GOMEMLIMIT=2.4G), add
GOGC=50, and add deploy.resources.limits.memory with the same value used in the
main compose (e.g., 3G) so OOM protection and GC tuning are consistent; update
both tn-db-1 and tn-db-2 entries accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cfc6c004-a798-4672-af97-58a0834a2776
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
compose.yamlgo.mod
resolves: #1316
reflecting changes based on trufnetwork/kwil-db#1682
Summary by CodeRabbit
Performance Enhancements
Chores