Add cert-manager support#196
Draft
Jakob-Naucke wants to merge 6 commits intotrusted-execution-clusters:mainfrom
Draft
Add cert-manager support#196Jakob-Naucke wants to merge 6 commits intotrusted-execution-clusters:mainfrom
Jakob-Naucke wants to merge 6 commits intotrusted-execution-clusters:mainfrom
Conversation
Warp is outsourcing multiple features with its move to Hyper v1 that we used or were soon going to use: - Client info like IP - Native TLS support These features are more broadly integrated in Axum, which kube-rs also recently moved to. Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Assisted-by: Claude
Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Assisted-by: Claude
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
In the trustedexecutioncluster CRD, add optional secret name for a cert-manager shaped certificate. In testing, use cert-manager to create a certificate. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Assisted-by: Claude
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @alicefr. Haven't written docs yet but you can get an idea of where it's going by looking at
api/trusted-cluster-gen.go,test_utils::set_certificates.Doesn't include verification for attestation key register. I used the same method as for register server, but I was under the impression the root certificate added in Ignition, which works for the merge from register server, isn't loaded at that time?
Didn't bother too much because that flow is subject to updates.
Fixes: #2
(at which I took first looks when it was new, hence the longest commit timespan in a PR from me to date)