Add design document for 2-phase attestation#68
Open
alicefr wants to merge 1 commit intotrusted-execution-clusters:mainfrom
Open
Add design document for 2-phase attestation#68alicefr wants to merge 1 commit intotrusted-execution-clusters:mainfrom
alicefr wants to merge 1 commit intotrusted-execution-clusters:mainfrom
Conversation
Signed-off-by: Alice Frosi <afrosi@redhat.com>
Contributor
There was a problem hiding this comment.
- Remote attestation is initiated by Ignition but performed by the attester, isn't it?
- By "attestation token", you mean one à la https://github.com/confidential-containers/trustee/blob/main/attestation-service/docs/grpc-as.md#quick-start? Is it going to verify against Trustee (that should be in the diagram) or something else (what/how?)?
- Interaction between Ignition and Trustee attester for the disk key phase maybe?
- I know the diagram in the booting design document is mighty large as is, but I'm not sure I'd split it up this way where the reader must basically merge this diagram into a bigger slightly inaccurate diagram in their head to understand the flow. It would be easier if they could append two diagrams, e.g. if you split by phase? Then you could drop the registration service in the second phase.
uril
reviewed
Nov 17, 2025
| - Uses generic reference values for the image (no UUID) | ||
| - Proves the platform is running in a confidential computing environment | ||
|
|
||
| 2. **Attestation Token Received**: Trustee Attester validates the attestation and returns an attestation token |
Contributor
There was a problem hiding this comment.
Trustee validates ... (remove Attester)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.