Open
Conversation
Author
|
Please feel free to say this is a bad idea but think we want to start from a up to date repo and we should be able to build from any release tags also not 100% sure we need to do anything special with it as we were doing as it doesnt matter if we build extra docker images as we compose only what we need but happy to discuss |
Author
|
For reference this is our current but not been done in a long time process https://github.com/trustpilot/datalake-ingestiontools/blob/master/docs/builddocker.md |
davidwalker-tp
approved these changes
Mar 11, 2022
davidwalker-tp
left a comment
davidwalker-tp
left a comment
There was a problem hiding this comment.
I'm not going to pretend I've read all 1555 commits, but let's give it a try as a means of getting our fork up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync from upstream so we can build newer confluent docker images for upgrade