Open
Conversation
New tests cheking the call for instance methods were added in the user model spec.
Some duplicate data were found and removed inside the pt locale about date formats.
The application now tests contract validations about the record attributes with the help of FactoryBot. A new contract spec was created with a contract builder for FactoryBot. Also the contract validations were updated to validate the contract attributes.
Both files were modified according with Rubocop code style evaluation manualy and automaticaly.
Contributor
|
@Pedro-Pezoa se esse PR foi feito sobre o #24 então este deve ser mesclado no #24 e o #24 deve ter a master como destino ;) |
Both files were modified to repair the broken build from Travis about the first 6 contract tests because of a error regarding a NillClass error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is focused to add and cover all contract model/controller tests with Rspec.