docs: AI-HPP v4.1.1 — threat model, architecture, and red-team clarifications#65
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af1f35918a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Override capability for ZTAH/CCB layers. | ||
|
|
||
| This attack model is sufficient to validate mitigations for: | ||
| - T-3.4-001. |
There was a problem hiding this comment.
Fix threat ID in mitigation coverage list
The coverage list references T-3.4-001, but that threat ID does not exist in the repository (the corresponding multi-agent entry is T-4.1-001 in annex/A-THREAT-MODEL.md). This breaks traceability for auditors or tooling that map red-team results to threat definitions, because the reported validation cannot be resolved to a defined threat item.
Useful? React with 👍 / 👎.
| - Access to lineage roots. | ||
| - Override capability for ZTAH/CCB layers. | ||
|
|
||
| This attack model is sufficient to validate mitigations for: |
There was a problem hiding this comment.
Narrow validation claim for key-compromise threat
This section claims the attack model is sufficient to validate T-4.1-004, but the same section states the adversary had no access to signing keys or privileged bypass, while T-4.1-004 explicitly includes key extraction/identity-compromise mechanics in annex/A-THREAT-MODEL.md. As written, the report overstates test coverage for that threat class and can mislead readers about what was actually validated.
Useful? React with 👍 / 👎.
Motivation
Description
annex/A-THREAT-MODEL.mdto usepolicy-lineage hash-chain verificationand addedT-4.1-004 Key Drift / Signing Identity Compromisewith attack mechanics, detection signals, mitigations, and Evidence Vault fields (key_id,rotation_epoch,revocation_flag,lineage_root_hash).AI_HPP_ARCHITECTURE_V4.mdto emphasize the MDP safe graph terminology and add4.5 Normative Requirements Boundary (v4.1.1)clarifying which sections are normative vs advisory.RED_TEAM_AUDIT_REPORT.mdwithAttack Model Capability (v4.1.1)describing surface coverage, model/agentic capabilities, multi-agent test rig, and cryptographic bypass assumptions that validate mitigations including the newT-4.1-004entry.0e9e148and the PR created with the described summary.Testing
git diff --checkto verify no patch/whitespace issues and it passed successfully.git diff -- AI_HPP_ARCHITECTURE_V4.md RED_TEAM_AUDIT_REPORT.md annex/A-THREAT-MODEL.mdto confirm intended edits were applied.git status --shortand committed the changes withgit commit, which completed successfully and produced commit0e9e148.Codex Task