made entire row clickable #522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonbusse
requested review from
akgupta89,
ckrajewski and
exxonvaldez
as code owners
Member
|
It looks like you can click on the colored chips, but the mouse stays looking like a "pointer" instead of a "hand". The mouse does look like a "hand" over the rest of the row. Perhaps some small CSS tweak is needed. |
hathix
requested changes
Feb 13, 2020
Member
hathix
left a comment
hathix
left a comment
There was a problem hiding this comment.
Looks good, just a few pieces of feedback:
- As I mentioned, make sure the "chips" have a "hand" icon instead of a "pointer" icon.
- I see that you removed the NavLink class from the route name in each row, which is good, but I think the blue-ish coloring of the route name helps it stand out in a busy UI. Can you use a
<span>to give the route name a blue color again? (I think it's likeclass="text-primary")
Other than that, looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396
Proposed changes
Added link to table row instead of just first table cell
...
Link to demo, if any
https://open-transit-row.herokuapp.com/
...