-
Couldn't load subscription status.
- Fork 66
Implement Promise All Settled #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6271720 to
16237ab
Compare
a68dc67 to
fae782c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this looks great! Only one real blocking nit to pick, and then a couple of suggestions on reducing some repetition in the resolving code.
Absolutely stellar stuff! <3
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...trol_abstraction_objects/promise_objects/promise_abstract_operations/promise_group_record.rs
Outdated
Show resolved
Hide resolved
...m/src/ecmascript/builtins/control_abstraction_objects/promise_objects/promise_constructor.rs
Outdated
Show resolved
Hide resolved
...tins/control_abstraction_objects/promise_objects/promise_abstract_operations/promise_jobs.rs
Outdated
Show resolved
Hide resolved
bbf3be7 to
295b9eb
Compare
…ll and PromiseAllSettled
…ection for PromiseAll and PromiseAllSettled, streamlining promise reaction processing.
… fulfillment and rejection handling, improving code clarity and reducing duplication.
5c6585a to
72715b1
Compare
No description provided.