Skip to content

Conversation

@komyg
Copy link
Contributor

@komyg komyg commented Oct 4, 2025

No description provided.

@komyg komyg force-pushed the feature/promise.all_settled branch from 6271720 to 16237ab Compare October 11, 2025 11:10
@komyg komyg requested a review from aapoalas October 14, 2025 12:38
@komyg komyg marked this pull request as ready for review October 14, 2025 12:38
@komyg komyg force-pushed the feature/promise.all_settled branch from a68dc67 to fae782c Compare October 14, 2025 12:41
Copy link
Member

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks great! Only one real blocking nit to pick, and then a couple of suggestions on reducing some repetition in the resolving code.

Absolutely stellar stuff! <3

@komyg komyg force-pushed the feature/promise.all_settled branch from bbf3be7 to 295b9eb Compare October 27, 2025 13:30
@komyg komyg force-pushed the feature/promise.all_settled branch from 5c6585a to 72715b1 Compare October 28, 2025 11:49
@komyg komyg requested a review from aapoalas October 28, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants