fix: Defer index creation on empty/insufficient tables#71
Merged
Conversation
Add row count guard before attempting vector/FTS index creation to prevent noisy error messages when LanceDB tables have insufficient training data (< 256 rows for IVF/PQ indices). Changes: - Add MIN_ROWS_FOR_INDEX constant (256) for LanceDB training data requirement - Add countRows() check before createIndex() in both createVectorIndexWithRetry and createFtsIndexWithRetry - Silently defer index creation with info log instead of 3 retry errors - Add countRows to LanceTable type definition - Add 6 test cases for empty/insufficient row scenarios Fixes #70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70
Add row count guard before attempting vector/FTS index creation to prevent noisy error messages when LanceDB tables have insufficient training data (< 256 rows for IVF/PQ indices).
Problem
When starting with an empty LanceDB table, the system produces noisy error messages:
Solution
MIN_ROWS_FOR_INDEX = 256constant (LanceDB IVF/PQ training requirement)table.countRows()before attempting index creation[store] Deferring vector index creation: 0 rows found (need ≥ 256)Changes
src/store.tscountRowstype,MIN_ROWS_FOR_INDEXconstanttest/unit/index-race-condition.test.tsTest Results
Impact
Closes #70