fix: improve memory_search retry logic for Node 22#75
Merged
Conversation
added 2 commits
April 9, 2026 00:04
- Add initial 200ms delay after capture before first search attempt - Increase retry count from 3 to 5 - Increase delay between retries from 100ms to 150ms - Simplify retryWithDelay to return last result instead of throwing
updateMemoryUsage implements delete+add internally. When fire-and-forget, a subsequent memory_search can land in the delete/add gap and observe zero rows, returning 'No relevant memory found.' in Node 22. Fix: await the update in memory_search. Test: remove unnecessary retry/delay workaround now that root cause is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix flaky test
memory_delete and memory_clear reject destructive operations without confirmationon Node 22.Problem
Solution
Verification