update tsci snapshot logic#548
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| - `-u, --update` – write new snapshots to disk. | ||
| - `--force-update` – force writing snapshots even when no visual diff is detected. | ||
| - `--3d` – also generate 3D preview snapshots. | ||
| - `--3d` – generate schematic, PCB, and 3D preview snapshots. |
There was a problem hiding this comment.
??? that's not what --3d does
There was a problem hiding this comment.
that is not what this flag does, this flag adds the 3d preview snapshots
| By default, only the PCB and schematic snapshots are produced. | ||
|
|
||
| Running without `--update` verifies that the generated output matches the existing snapshots. Differences cause a non-zero exit code. | ||
| If `--3d` is specified, the command produces PCB, schematic, and 3D snapshots |
There was a problem hiding this comment.
that's how the cli working !
There was a problem hiding this comment.
that is not what this flag does, the flag adds to the existing outputs
|
@seveibar ig this is the snapshot behaviour, maybe if this seems abnormal then we need to fix the cli snapshot ig ? need you opinion. |
| --- | ||
|
|
||
| `tsci snapshot` renders your boards to SVG images and compares them with saved snapshots. | ||
| `tsci snapshot` renders schematic and PCB SVG images and compares them with saved snapshots. It does not generate 3D snapshots unless you explicitly pass `--3d`. |
There was a problem hiding this comment.
why would this be in the tagline
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
check your work carefully, remember that rejection ratio is measured in the contribution tracker SPR table
2 participants
No description provided.