fix: support jst_ph_N format and dynamic PH silkscreen sizing#518
Open
lucaferri-dev wants to merge 2 commits intotscircuit:mainfrom
Open
fix: support jst_ph_N format and dynamic PH silkscreen sizing#518lucaferri-dev wants to merge 2 commits intotscircuit:mainfrom
lucaferri-dev wants to merge 2 commits intotscircuit:mainfrom
Conversation
Parse trailing pin count from footprint strings like jst_ph_4, jst_ph_6. Also compute PH silkscreen body width from pin count instead of hardcoding. Closes tscircuit#495 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add kicad parity test comparing jst_ph_4 against JST_PH_B4B-PH-K_1x04_P2.00mm_Vertical from KiCad library. Also fix biome formatting in jst_ph_4.test.ts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Added a KiCad parity test for jst_ph_4 comparing against JST_PH_B4B-PH-K_1x04_P2.00mm_Vertical from the KiCad library. Also fixed the biome formatting issue. |
Author
|
Already added in commit 022a391 — the kicad parity test for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jst_ph_4,jst_ph_6, etc. format (trailing pin count after variant)jst_ph_4generating 4 padsCloses #495
Test plan
jst_ph_4generates 4 plated holesjst_ph_6generates 6 plated holesjst4_ph,jst2_ph) still work🤖 Generated with Claude Code