-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Specialized packing strategy for decoupling capacitors #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Specialized packing strategy for decoupling capacitors #28
Conversation
|
@natinew77-creator is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
|
Ready for review! If there is any feedback, I am happy to address it. |
|
@natinew77-creator Join our discord for discussion and you can also drop your pr link in reviewme channel on the discord for fast reviews |
| console.log(`Group: ${group.decouplingCapGroupId}`) | ||
| console.log(` Main Chip: ${group.mainChipId}`) | ||
| console.log(` Caps: ${group.decouplingCapChipIds.join(", ")}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove console.log
seveibar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the evidence this works?
|
Hi @seveibar and @techmannih, I've updated the PR with the requested visual evidence and addressed the feedback regarding console logs and test assertions. |
seveibar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs visual snapshot testing (i.e. svgs, as is our standard practice)

/claim #15
Implements a specialized packing strategy for decoupling capacitors to ensure neat, linear layouts.
Changes
packDecouplingCapsmethod toSingleInnerPartitionPackingSolver.Verification
Added
tests/DecouplingCapacitorPacking.test.tswhich verifies:The test output confirms the linear arrangement: