You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a particular reason why lib is set for these files? As I understand the TSConfig reference, the lib option defaults to target meaning it could be omitted when they match.
If there is no lib in tsconfig.json, TypeScript will load all node_modules/@types/* packages as its' libraries. This will cause some unexpected side effects. So personally, I prefer specifying lib in tsconfig.json too.
Note that this PR will break people targeting older versions of node, since they would not have these later syntaxes. That's a main reason not to bump them.
I would personally not do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libandtargetare not the same in@tsconfig/nodexx#271 (comment), TS 5.5 now support es2023 target.libshould be es2022.Closes #217.