Open
Conversation
According to http://www.tcpdump.org/linktypes.html the value is 101 but in reality it is 12 (and on OpenBSD 14). While browsing through the list on OpenBSD the DLT_LOOP is 12 (and not 108). In the long it might make sense to back these values with cgo (and pcap/bpf.h).
Author
|
I don't know your taste. I can start using pcap.DLT_RAW and pcap.DLT_RAW (which in turn would return C.DLT_RAW) to make this work universally. The reason I didn't do it yet is the question if you see a hierarchy between pcap.go and enums.go (e.g. if enums.go should depend on elements from pcap.go) or if enums.go should replicate the ldflags/cflags and import "C" directly as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to http://www.tcpdump.org/linktypes.html the value is 101
but in reality it is 12 (and on OpenBSD 14). While browsing through
the list on OpenBSD the DLT_LOOP is 12 (and not 108). In the long it
might make sense to back these values with cgo (and pcap/bpf.h).