FileNode: Make FileNodeID an enum class#21
Merged
tshikaboom merged 1 commit intomasterfrom Aug 28, 2020
Merged
Conversation
blu-base
reviewed
Aug 28, 2020
blu-base
reviewed
Aug 28, 2020
tshikaboom
force-pushed
the
fndid-enum-class
branch
from
5db727c to
134dfe7
Compare
Owner
Author
|
I adressed these and force-pushed a new commit (as it is simple enough). Can you have a small look just to confirm this is all right? |
blu-base
approved these changes
Aug 28, 2020
Contributor
|
Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been extracted from #19.
This converts
enum fnd_idtoenum class FndId, making the code more readable and less verbose in regards to theenumkeyword. These changes should not have a functional impact.