Skip to content

fix pb_module name in typings#11

Open
maksimryndin wants to merge 1 commit intotsloughter:masterfrom
maksimryndin:bugfix-pb_module_name
Open

fix pb_module name in typings#11
maksimryndin wants to merge 1 commit intotsloughter:masterfrom
maksimryndin:bugfix-pb_module_name

Conversation

@maksimryndin
Copy link
Copy Markdown

If protofile name contains illegal characters for module name then we should wrap pb module name in single quotes in all typings

@tsloughter
Copy link
Copy Markdown
Owner

Thanks. I kinda prefer to only add the ' if it is required. And wouldn't the same be needed for {{method}}? Not sure what proto allows in the method name, but maybe can have something that must be quoted in atoms?

I think we could instead do something like converting the atoms to strings with io_lib:format("~p", [PbModule]) which will add the ' if needed and then that'll be included in the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants