Refactor the timestamp conversion for efficiency and less duplication#17
Merged
tsloughter merged 1 commit intotsloughter:mainfrom Oct 7, 2025
Merged
Conversation
tsloughter
reviewed
Oct 2, 2025
richcarl
force-pushed
the
refactor-timestamp
branch
from
15cb463 to
c3ef52b
Compare
tsloughter
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the timestamp encoding hard to read and hard to verify that it did the right thing in the different cases, so I refactored it, also getting rid of unnecessary tuple consing. Passes the proper tests.