Open
Conversation
Author
|
will fix the build asap |
Intervals with >=24 hours or negative microseconds crashed with function_clause in calendar:seconds_to_time/1 which only accepts 0-86399. Replace the call to pg_time:decode_time/1 with a local decode_interval_time/1 that uses signed div/rem, correctly handling negative values, values exceeding 24 hours, and fractional seconds.
eratio08
force-pushed
the
fix/interval-signed-arithmetic
branch
from
840f5d6 to
63d3a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix/Feature (not sure) to support 25h (e,g, due to dst) and negative intervals which are valid intervals in postgres. Postgres does not normalize hours >24 into days, so even intervals with 100h are valid.
original pr: #24