Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Conversation

@tsshadow
Copy link
Owner

Summary

  • add a GitHub Actions workflow that runs the unit tests with coverage on every push
  • build and push the Docker image to Docker Hub when the tests succeed

Testing

  • not run (workflow change only)

https://chatgpt.com/codex/tasks/task_e_69037786f16c8326827b56ecfb7b8692

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +3 to +6
on:
push:
branches:
- '**'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restrict Docker pushes to release branches

The workflow runs on every branch (branches: ['**']), yet the build-and-push job unconditionally logs into Docker Hub and pushes tsshadow/music-importer:latest/${{ github.sha }}. This means any push to a feature or experimental branch will publish a latest image, overwriting whatever was last released from main. If contributors push work-in-progress changes, the public Docker tag no longer represents production code. Consider limiting the workflow or the push step to trusted branches (e.g. if: github.ref == 'refs/heads/main') or using branch-specific tags so that only vetted releases update latest.

Useful? React with 👍 / 👎.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants