Add modname command#47
Open
Abkwreu wants to merge 8 commits intotterrag1098:masterfrom
Abkwreu:master
Open
Conversation
Owner
|
Clean up all the copypasta (seriously this command is 99% just a copy of drama) and follow the pattern of using a submodule rather than dumping the entire src in the resources. |
Author
|
Cleaned up the command file and added as submodule |
Owner
|
What I meant was...avoid copying code entirely. I don't want two commands that share almost all their code. They should inherit from a common class or have their logic extracted to a common location. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new command that generates a Minecraft mod name from http://mod-name-generator.herokuapp.com/