Closed
Conversation
✅ Deploy Preview for pyra-4-documentation canceled.
|
dostuffthatmatters
force-pushed
the
dev-coccon-spain
branch
from
6de9a1c to
6362d88
Compare
dostuffthatmatters
force-pushed
the
dev-coccon-spain
branch
from
e6f3243 to
4779797
Compare
✅ Deploy Preview for pyra-4-documentation canceled.
|
Add enclosure interface
Add enclosure types
Add enclosure logger
Add config and state to central schemas
Extend enclosure interface
Add enclosure thread
Add coccon spain thread to mainloop
Fix CI tests
Add UI code
Update enclosure code after rebasing to 4.2.5
dostuffthatmatters
force-pushed
the
dev-coccon-spain
branch
from
90dd972 to
e207fe5
Compare
Rename "COCCON Spain Enclosure" to "AEMET Enclosure" in pyra core
Rename "COCCON Spain Enclosure" to "AEMET Enclosure" in UI
add pyright dependency and config
fix all pyright issues
add pyright to pytests
Simplify import paths for enclosure codes
Merge TUM and aemet enclosure logger code
Add actually used state
✅ Deploy Preview for pyra-4-documentation ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Add actual configuration schema
Add new config parameters to config UI
Add actual enclosure interface
Add correct state to UI parser
Render current state in overview page
Add variable "opened_due_to_elevated_internal_humidity"
Update default AEMET enclosure config
Refine state rendering on overview page
Update browerlist for UI build
Refine datalogger reading logic
Improve the performance of the logs tab
dostuffthatmatters
force-pushed
the
dev-coccon-spain
branch
from
374ed6f to
f72eec7
Compare
Make state updates more error-resistant
Add headless enclosure scripts and add docstrings to all headless scripts
Debug state parsing
Implement TASMATO power plug
Rename "toggle_em27_power" to "use_em27_power_plug"
Read EM27 power plug throughput
Render power supply variables in UI
Update default em27 power plug config
Add power plug to integration tests
dostuffthatmatters
force-pushed
the
dev-coccon-spain
branch
from
b32092c to
c698c3c
Compare
dostuffthatmatters
force-pushed
the
dev-coccon-spain
branch
from
c434ac4 to
6faa9e0
Compare
Simplify enclosure state read interface -> combine read from datalogger and power plug
dostuffthatmatters
force-pushed
the
dev-coccon-spain
branch
2 times, most recently
from
f707547 to
323d5b6
Compare
Debug and refine
dostuffthatmatters
force-pushed
the
dev-coccon-spain
branch
from
323d5b6 to
bb8e219
Compare
Finish up enclosure integration in other threads
Member
Author
|
Closing because we are performing this merge in PR ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to do for Pyra Core:
Define the config variables you need in
packages/core/types/enclosures/coccon_spain_enclosure.pyEverything that should be configurable without a software update.
Define the state variables you need in
packages/core/types/enclosures/coccon_spain_enclosure.pyEverything you need in the operational logic inside Pyra (humidity, enclosure position, etc.) or that you want to display in the UI.
Define the functions how to read from/write to the datalogger in
packages/core/interfaces/enclosures/coccon_spain_enclosure_interface.pyprobably simply HTTP requests
Define the operational logic inside
packages/core/threads/enclosures/coccon_spain_enclosure_thread.pypowering up/down the spectrometer, opening/closing the cover, etc.
Define the datalogger variables you want to archive in CSV files in
packages/core/utils/coccon_spain_enclosure_logger.pyThings to do for the UI:
packages/ui/src/utils/zustand-utils/config-zustand.tsandpackages/ui/src/custom-types.tspackages/ui/src/utils/zustand-utils/core-state-zustand.tspackages/ui/src/components/overview/system-state.tsxYou can look at the TUM Enclosure equivalents of these files to get an inspiration of what could be done. Feel free to ping me here if you have any questions.