Completes the challenge in approximately 1.2 sec on my machine (M4 Macbook Pro).#5
Open
cubicle-jockey wants to merge 1 commit intotumdum:mainfrom
Open
Completes the challenge in approximately 1.2 sec on my machine (M4 Macbook Pro).#5cubicle-jockey wants to merge 1 commit intotumdum:mainfrom
cubicle-jockey wants to merge 1 commit intotumdum:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello tumdum!
Here is my 1brc. Hopefully I followed the proper guidelines for the challenge, but admittedly I had trouble finding specific info on requirements (other than your repo being the one to use for Rust).
Tested on my machine (M4 Macbook Pro), my code shows roughly a 40% performance improvement.
Something to note however is that during my testing, there were discrepancies with the averages for 16 cities. All were 0.0 vs 0.1 or 0.0 vs -0.1. I expanded out to 3 decimal places to spot check and I believe mine to be correct (correctly rounded when :.1 precision is used).
Please let me know there's something I need to correct (again, I had trouble finding specific requirements).
Thanks!