Open
Conversation
CounterPillow
force-pushed
the
gcc-7-warnings
branch
from
d20dc4b to
220a513
Compare
Add fallthrough comments to tinyformat.hpp to disable -Wimplicit-fallthrough warnings. Also disable -Wattributes in embree, since it generates a lot of warnings from that.
CounterPillow
force-pushed
the
gcc-7-warnings
branch
from
220a513 to
582b487
Compare
Owner
|
Thanks for that! Is it possible to just use -Wno-implicit-fallthrough instead of modifying tinyformat? I'd like to avoid modifying third-party libraries, since those changes will be overwritten when the library is updated. |
|
Better yet, why not just update tinyformat? This seems to be fixed already there… |
Contributor
Author
|
Well, you are commenting over a year later |
|
Originally I was going to suggest fixing tinyformat instead of just disabling the warning. It's an easy patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable
-Wimplicit-fallthroughusing fallthrough comments, since we can't use C++17 attributes.Also disable
-Wattributesin embree, since it generates a lot of warnings from that.