Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds Windows support to the project by making changes to ensure cross-platform compatibility in file I/O operations and test assertions.
Changes:
- Added Windows to the CI/CD test matrix to run tests on Windows, macOS, and Linux
- Fixed file encoding in edge file parsing to ensure consistent text handling across platforms
- Migrated test assertions from numpy to PyTorch for better device/dtype compatibility
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Added windows-latest to the OS matrix to enable Windows CI testing |
src/tcrgnn/graph_gen/_io.py |
Added encoding="utf-8" and newline="" parameters to file.open() for consistent cross-platform text file handling |
tests/generate_graph_tests/test_build_graph.py |
Changed from np.allclose on .numpy() conversions to torch.allclose with proper device/dtype matching for better cross-platform tensor comparison |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.