Prvocisla #231
Open
Prvocisla #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vymazanie vzorového súboru 'example.py'
Vloženie hlavného programu
Odstránenie zvyšných errorov a warningov cez flake8
Test pre funkciu 'prvocislo' s testovacími hodnotami do 1000
Test pre funkciu 'prvocislo_mr' s hodnotami väčšími ako 1000
turecekt
requested changes
Jan 27, 2023
Owner
There was a problem hiding this comment.
- v Actions zrušte workflow pages-build-deployment (nastavit disable vpravo nahoře pod tlačítkem [...] zde: https://github.com/Cvachtacik/vs_project/actions/workflows/pages/pages-build-deployment)
- soubory main.py, test_prvocislo.py a test_pvocislo_mr.py přesunout do kořenového adresáře
- zrušit adresáře Prvočísla a PyDOC a docs včetně obsahu
- smazat soubory .DS_Store a main.html
- main.py upravit takto:
Dokumentácia html vygenerovaná pomocou pdoc
turecekt
requested changes
Jan 28, 2023
Owner
turecekt
left a comment
turecekt
left a comment
There was a problem hiding this comment.
- testy už fungují, ještě vyčistit kód, aby prošel přes statickou analýzu nástrojem flake8 viz chyby zde: https://github.com/Cvachtacik/vs_project/actions/runs/4029052153/jobs/6926551827
- v Actions zrušte spouštění workflow pages-build-deployment (nastavit disable vpravo nahoře pod tlačítkem [...] zde: https://github.com/Cvachtacik/vs_project/actions/workflows/pages/pages-build-deployment)
- odstranit adresáře .pytest_cache a docs včetně obsahu
Úprava kódu main.py, test_prvocislo.py a test_prvocislo_mr.py tak, aby vyhovoval testu Flake8
…into Prvocisla
Vymazanie adresárov .pytest_cache a docs
turecekt
requested changes
Jan 28, 2023
test_prvocislo.py
Outdated
Comment on lines
6
to
7
| def test_prvocislo(self): | ||
| self.assertFalse(prvocislo(1)) |
Owner
There was a problem hiding this comment.
Suggested change
| def test_prvocislo(self): | |
| self.assertFalse(prvocislo(1)) | |
| def test_prvocislo(): | |
| assert prvocislo(1) is False |
turecekt
requested changes
Jan 28, 2023
Owner
turecekt
left a comment
turecekt
left a comment
There was a problem hiding this comment.
- v Actions opětovně povolit pouštění workflow Python checker(https://github.com/Cvachtacik/vs_project/actions/workflows/python_checker.yml) a naopak zrušit pouštění workflow pages-build-deployment (nastavit disable vpravo nahoře pod tlačítkem [...] zde: https://github.com/Cvachtacik/vs_project/actions/workflows/pages/pages-build-deployment)
- opravit kód tak, aby prošel přes workflow Python checker, tzn včetně flake8
Author
Povolené púšťanie workflow Python checker, ale u pages-build-deployment nemám možnosť pre disable viz tu: |
Úprava komentárov, aby vyhovovali pre flake8
turecekt
requested changes
Jan 29, 2023
Owner
turecekt
left a comment
turecekt
left a comment
There was a problem hiding this comment.
Ještě poslední drobnosti, stejně doplnit u funkce prvocislo_mr.
Posledné drobnosti
Posledné úpravy
turecekt
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.