This repository was archived by the owner on May 23, 2025. It is now read-only.
Ensure correct font weight for boost/fav count in all locales #5105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tak
approved these changes
May 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This never worked as intended when the font weight was defined inside the resources. Seems like Weblate is not dealing with that correctly.
If there is
<b>%1$s</b>used inside the resource, it gets stripped bygetQuantityString. To work around that, it needs to be HTML escaped<b>%1$s</b>and then passed tofromHtml.Since for some reason not even the source strings got the
<b>%1$s</b>correct everywhere, I'm changing it to a completely code based version that will always be right no matter what is defined in the resource.