Skip to content

Fix env overrides when config file doesn't exist #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tutunak merged 2 commits into from
Feb 1, 2026
Merged

Fix env overrides when config file doesn't exist #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec9ae18
Initial plan
Copilot Feb 1, 2026
f553a05
Fix env overrides when config file doesn't exist
Copilot Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ func Load() (*Config, error) {

data, err := os.ReadFile(path)
if os.IsNotExist(err) {
cfg.applyEnvOverrides()
return cfg, nil
}
if err != nil {
Expand Down
33 changes: 33 additions & 0 deletions internal/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,39 @@ func TestEnvOverrides(t *testing.T) {
}
}

func TestEnvOverridesWithoutConfigFile(t *testing.T) {
tmpDir := t.TempDir()
t.Setenv("XDG_CONFIG_HOME", tmpDir)

// Set env vars without creating a config file
t.Setenv("JIRA_URL", "https://env.atlassian.net")
t.Setenv("JIRA_EMAIL", "env@example.com")
t.Setenv("JIRA_API_TOKEN", "env-token")
t.Setenv("JIRA_PROJECT", "ENVPROJ")
t.Setenv("JIRA_STATUS", "Done")

loaded, err := Load()
if err != nil {
t.Fatalf("unexpected error: %v", err)
}

if loaded.Jira.URL != "https://env.atlassian.net" {
t.Errorf("expected env URL override, got %q", loaded.Jira.URL)
}
if loaded.Jira.Email != "env@example.com" {
t.Errorf("expected env email override, got %q", loaded.Jira.Email)
}
if loaded.Jira.APIToken != "env-token" {
t.Errorf("expected env token override, got %q", loaded.Jira.APIToken)
}
if loaded.Defaults.Project != "ENVPROJ" {
t.Errorf("expected env project override, got %q", loaded.Defaults.Project)
}
if loaded.Defaults.Status != "Done" {
t.Errorf("expected env status override, got %q", loaded.Defaults.Status)
}
}

func TestValidate(t *testing.T) {
tests := []struct {
name string
Expand Down